Bitbucket

#1

• View jespern's profile
• jespern's repositories »
  • cx
  • cx-patches
  • pyetsy
  • ldap2vcard
  • puck
  • hgswitch
• Send message

→ Changed milestone from nothing to 1. Above the Law.

→ Changed responsible from nobody to jespern.

→ Changed type from proposal to enhancement.

→ Changed status from new to open.

#2

• View madssj's profile
• madssj's repositories »
  • mercurial-trac-hook
• Send message

→ Changed status from open to resolved.

I've fixed this. Sorry for the issue theft.

#3

• View eirik's profile
• eirik's repositories »
• Send message

→ Changed responsible from jespern to madssj.

→ Changed status from resolved to open.

Regression.

#4

• View madssj's profile
• madssj's repositories »
  • mercurial-trac-hook
• Send message

Regression?

#5

• View eirik's profile
• eirik's repositories »
• Send message

Used to work, doesn't anymore :)

#6

• View madssj's profile
• madssj's repositories »
  • mercurial-trac-hook
• Send message

Works great here. Just looked at the __cmp__ method and the call to sorted() and both are intact in tip.

How does it look at your end? Are you running python 2.5 or 2.4? (not that it should matter) Are the two calls I've mentioned intact in your copy? Template changes? Dirty cache?

#7

• View madssj's profile
• madssj's repositories »
  • mercurial-trac-hook
• Send message

Silly comment system, you should preserve my newlines!

#8

• View eirik's profile
• eirik's repositories »
• Send message

Hm, I was actually just seeing it live, is your repository-dropdown sorted on bitbucket.org now?

#9

• View madssj's profile
• madssj's repositories »
  • mercurial-trac-hook
• Send message

My repository dropdown is sorted on bitbucket.org, yes.

#10

• View eirik's profile
• eirik's repositories »
• Send message

Ah, I see, the problem is probably the repositories where I'm owner. All my repos are sorted correctly, except that the first repo in the dropdown is my "Testing" repo, which I added recently.

#11

• View madssj's profile
• madssj's repositories »
  • mercurial-trac-hook
• Send message

Is it actually called Testing with a capital t?

#12

• View madssj's profile
• madssj's repositories »
  • mercurial-trac-hook
• Send message

Right, just verified that repository names are not lowercased uppon creation. I'll just commit a fix to the __cmp__ method, that will force the lowercoding, but it's not a propper fix, #234 is.

#13

• View madssj's profile
• madssj's repositories »
  • mercurial-trac-hook
• Send message

On second hand, I will not fix this in the sorting, but leave the fix for the other ticket. Otherwise the sorting will just be forgotten, and will yield an unexpected result.

The code needed to fix it would have been:

1
2
3
4

def __cmp__(self, other):
        if isinstance(other, self.__class__):
            return cmp(self.name.lower(), other.name.lower())
        return cmp(self.name.lower(), other.lower())

#14

• View madssj's profile
• madssj's repositories »
  • mercurial-trac-hook
• Send message

→ Changed status from open to resolved.